Skip to content

Update GRPCIO version for Python 3.8 and higher. #1294

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 5 commits into from
Jul 28, 2023
Merged

Update GRPCIO version for Python 3.8 and higher. #1294

merged 5 commits into from
Jul 28, 2023

Conversation

pdthummar
Copy link
Contributor

@pdthummar pdthummar commented Jul 27, 2023 •
edited
Loading

Description

Fixes #

PR information

  • The title of the PR is clear and informative.
  • There are a small number of commits, each of which has an informative message. This means that previously merged commits do not appear in the history of the PR. For information on cleaning up the commits in your pull request, see this page.
  • If applicable, the PR references the bug/issue that it fixes in the description.
  • New Unit tests were added for the changes made and CI is passing.

Quality of Code and Contribution Guidelines

@codecov
Copy link

codecov bot commented Jul 27, 2023 •
edited
Loading

Codecov Report

Merging #1294 (db6f609) into dev (a8a4d42) will decrease coverage by 52.21%.
The diff coverage is n/a.

❗ Current head db6f609 differs from pull request most recent head 87528da. Consider uploading reports for the commit 87528da to get more accurate results

@@             Coverage Diff             @@
##              dev    #1294       +/-   ##
===========================================
- Coverage   84.51%   32.31%   -52.21%     
===========================================
  Files          34       34               
  Lines        1925     1925               
  Branches      366      281       -85     
===========================================
- Hits         1627      622     -1005     
- Misses        228     1302     +1074     
+ Partials       70        1       -69
Flag Coverage Δ
unittests 32.31% <ø> (-52.16%) ⬇️

Flags with carried forward coverage won't be shown. Click here to find out more.

see 23 files with indirect coverage changes

@pdthummar pdthummar changed the title Revert Fixing vulnerabilities PR#1292 Revert Fix for Python 3.7 Jul 28, 2023
@pdthummar pdthummar changed the title Revert Fix for Python 3.7 Revert GRPCIO version for Python 3.7 Jul 28, 2023
@pdthummar pdthummar changed the title Revert GRPCIO version for Python 3.7 Update GRPCIO version for Python 3.8 and higher. Jul 28, 2023
gavin-aguiar
gavin-aguiar reviewed Jul 28, 2023
View reviewed changes
@gavin-aguiar gavin-aguiar merged commit 242853b into dev Jul 28, 2023
@gavin-aguiar gavin-aguiar deleted the pthummar/revert_libs_version branch July 28, 2023 19:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gavin-aguiar gavin-aguiar gavin-aguiar approved these changes

@vrdmr vrdmr Awaiting requested review from vrdmr vrdmr is a code owner

@YunchuWang YunchuWang Awaiting requested review from YunchuWang

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@pdthummar @gavin-aguiar